Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using type text instead number for avoid region issue #3538

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: using type text instead number for avoid region issue #3538

merged 1 commit into from
Sep 4, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Sep 3, 2024 •
edited
Loading

Describe Your Changes

  • replace type number with text for input to avoid region issue number format
  • prevent user input alphabets or symbol, the input should only accepted 0-9 and .

Now the value input allow 0.5 instead 0,5

Screenshot 2024-09-03 at 13 01 30

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Sep 3, 2024
@urmauur urmauur added this to the v.0.6.0 milestone Sep 3, 2024
@urmauur urmauur self-assigned this Sep 3, 2024
louis-jan
louis-jan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 28c6ba1 into dev Sep 4, 2024
9 checks passed
@urmauur urmauur deleted the fix/allow-floating-number branch September 4, 2024 15:58
@louis-jan louis-jan mentioned this pull request Sep 9, 2024
Merged
3 tasks
louis-jan added a commit that referenced this pull request Sep 9, 2024
@louis-jan
Revert "fix: using type text instead number for avoid region issue (#…
0c5ab22 
…3538)"

This reverts commit 28c6ba1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
v.0.6.0 (Jan x Cortex - Deprecated du...
Development

Successfully merging this pull request may close these issues.

bug: different region is causing input box not allowing float number with "."
2 participants
@urmauur @louis-jan